Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable -Werror when using Java 20 #467

Merged
merged 1 commit into from
Jul 3, 2023
Merged

disable -Werror when using Java 20 #467

merged 1 commit into from
Jul 3, 2023
+8 −4

Conversation

pjfanning
Copy link
Contributor

  • relates to Allow building on jdk19 #430
  • Java 19 is not LTS and Java 20 is latest non-LTS release
  • the compiler warnings leading to build failing (-Werror does this) is the main problem with using a new JDK to build Pekko

He-Pin
He-Pin approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 0db5d8d into apache:main Jul 3, 2023
17 checks passed
@pjfanning pjfanning mentioned this pull request Jul 3, 2023
Closed
@pjfanning pjfanning deleted the disable-Werror-java20 branch July 6, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@He-Pin He-Pin He-Pin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjfanning @He-Pin